Do not create trace log message when trace logging is not enabled

[lennehendrickx]

The "Can't take as work ..." trace message is created even when trace logging is not enabled. In our profiler we saw that this generates a significant amount of garbage. This PR only generates the message if trace logging is enabled.

Checklist

• Documentation (if applicable)
• Changelog

[lennehendrickx]

Hi Confluent Team,

This is generating quite some unnecessary garbage in our applications. Did you already have time to look into this? Or is there something we can/should do before this PR is considered?

Thanks!

[what-the-diff]

PR Summary

• Optimized log tracing - Improved performance by checking if trace logging is enabled before executing trace statements
• New method in ProcessingShard class - Added cantTakeAsWorkMsg(...) method to aid in handling exceptional cases when assigning work messages

[lennehendrickx]

Hi @rkolesnev,

I have added some more conditional checks to avoid unnecessary calculation of properties for trace logging when trace logging is not active.

[what-the-diff]

PR Summary

• Removed unnecessary log statements
  Unnecessary log.trace() and log.debug() statements were removed, making the code cleaner.

• Added cantTakeAsWorkMsg(...) method to ProcessingShard
  A new method called cantTakeAsWorkMsg(...) was added, providing better control over logging information during function calls, improving performance, and reducing unnecessary logs.

• Optimized logging in WorkManager
  The logging in WorkManager has been optimized, only printing messages if debug logging is enabled, reducing resource usage and improving overall application performance.

[lennehendrickx]

Hi @rkolesnev ,

Did the team already have time to look into this?

Thanks

[rkolesnev]

Hi @rkolesnev ,

Did the team already have time to look into this?

Thanks

Approved, merged.