Pl 176/dont drain issue #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niamhthornbury
requested review from
rkolesnev and
eddyv
and removed request for
rkolesnev
eddyv
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Need to update the license header in this file for CI to pass
|
closes #559 |
|
could you please prioritize merging this change given that it is already approved? |
|
Closing this as another fix has been identified and has been planned for work soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://confluentinc.atlassian.net/browse/PL-176
Updating don't drain to gracefully finish processing messages already being processed to match the DONT_DRAIN description of
Stop downloading more messages, and stop procesing more messages in the queue, but finish processing messages already being processed locally.Checklist