Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add synchronization to ensure proper intializaiton and closing of PCM… #627

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

antonmos
Copy link
Contributor

@antonmos antonmos commented Aug 17, 2023

…etrics singleton. fixes #617

Fixes NPE during shutdown described in #617

Checklist

  • Documentation (if applicable)
  • Changelog

@what-the-diff
Copy link

what-the-diff bot commented Aug 17, 2023

PR Summary

  • Version Update in Change-log

    • The change-log documentation was updated to reflect the introduction of a new software version 0.5.2.7. Features of this version include improved synchronization methods to enhance functioning of a component called PCMetrics.
  • Addition and Modification in PCMertics Java File

    • A new component called Timer was incorporated into the PCMetrics file via an import statement.
    • Import statements related to different functionalities from java.util were streamlined under java.util.* improving the code simplicity.
    • A previously private field, registeredMeters, was updated from a standard List to a synchronized List. This change enhances the field's security and safeguards it against potential simultaneous alterations.
  • Adds Synchronization to Methods

    • Certain methods - 'initialize', 'close' and 'removeMeter' were revamped with synchronization techniques. This would improve these methods' efficiency by preventing multiple threads from executing the code at the same time.
  • Code Formatting Improved

    • The code formatting was enhanced with additional indents and new lines to improve readability and maintainability.

@cla-assistant
Copy link

cla-assistant bot commented Aug 17, 2023

CLA assistant check
All committers have signed the CLA.

@antonmos antonmos marked this pull request as draft August 17, 2023 18:53
@antonmos antonmos marked this pull request as ready for review August 18, 2023 22:11
Copy link

@jhollandus jhollandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhollandus
Copy link

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ eddyv❌ antonmosYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @antonmos, we need you to sign the CLA to contribute this PR. Thanks.

@antonmos
Copy link
Contributor Author

signed it. thank you!

@rkolesnev rkolesnev merged commit 696e969 into confluentinc:master Aug 30, 2023
@antonmos
Copy link
Contributor Author

thanks for merging! any idea when you will release a new version?

@krvajal
Copy link

krvajal commented Aug 31, 2023

I got it working with https://jitpack.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while shutting down parallel consumers in 0.5.2.6
5 participants