Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated batchSize factor from target load; add a test case #662

Merged

Conversation

cloudhunter89
Copy link
Contributor

Addresses a bug identified in a slack thread (https://confluentcommunity.slack.com/archives/C051K2TJLPQ/p1699018828805729) which causes the inflight queue to scale by batchSize * batchSize * maxConcurrency * dynamicLoadFactor rather than batchSize * maxConcurrency * dynamicLoadFactor

Checklist

  • Documentation (if applicable)
  • Changelog

Copy link

cla-assistant bot commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

rkolesnev
rkolesnev previously approved these changes Nov 13, 2023
Copy link
Contributor

@rkolesnev rkolesnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one nitpick

Copy link

what-the-diff bot commented Nov 13, 2023

PR Summary

  • Updated Target Loading Computation for Inflight Records
    A tweak has been made to the relevant process in the CHANGELOG.adoc so that it computes the target loading for inflight records in a more efficient manner.

  • Altered getQueueTargetLoaded() Method
    The method getQueueTargetLoaded() in AbstractParallelEoSStreamProcessor.java has been changed, eliminating the multiplication by batch size, which results in more accurate performance.

  • New Test File Added
    A new test file AbstractParallelEoSStreamProcessorConfigurationTest.java was introduced to improve the reliability of the given software by enabling us to inspect its behavior under various conditions.

  • New File for Testing Internal and Configuration-based Interfaces
    A new file named TestParallelEoSStreamProcessor.java has been added. This provides us with methods for testing the internal functionality and configuration-based adjusting aspects of the AbstractParallelEoSStreamProcessor, ensuring the system works smoothly and correctly.

@rkolesnev rkolesnev merged commit 0c9b7da into confluentinc:master Nov 16, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants