Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NullPointerException on partitions revoked (#757) #758

Merged
merged 6 commits into from
May 7, 2024

Conversation

sangreal
Copy link
Contributor

@sangreal sangreal commented Apr 24, 2024

Description...
The race condition happens when there are partition revoked right after partition is assigned, and there are existing incompleteOffsets.

  1. partition assigned and incompleteOffsets existed
  2. right before begin to poll and process messages, it got revoked
  3. the processingShard has no data yet
  4. when revoked, try to delete entries with records from incompleteOffsets, no such record in entries

Checklist

  • Documentation (if applicable)
  • Changelog

@rkolesnev
Copy link
Contributor

@sangreal - were you able to reproduce the issue? Could you add a test that reproduces it and tests for regression?

@rkolesnev
Copy link
Contributor

/sem-approve

1 similar comment
@rkolesnev
Copy link
Contributor

/sem-approve

@sangreal sangreal force-pushed the fix/partition_revoke_npe branch from f8c6de3 to ed0bcc6 Compare May 4, 2024 01:53
@sangreal
Copy link
Contributor Author

sangreal commented May 4, 2024

@sangreal - were you able to reproduce the issue? Could you add a test that reproduces it and tests for regression?

@rkolesnev Thanks for the comment, I update the description and more details and UT is added.

@rkolesnev
Copy link
Contributor

/sem-approve

@rkolesnev
Copy link
Contributor

Hey @sangreal - thanks, can you please run license check / update license headers in updated / new files?
Refer to build output - https://confluentinc.semaphoreci.com/workflows/a37eff87-3a4f-493c-aa74-89d56d9a557a?pipeline_id=af6b4e93-5d9e-4e1e-9467-d0ee07c953ee.

@sangreal
Copy link
Contributor Author

sangreal commented May 7, 2024

@rkolesnev thanks, I updated pr and please help trigger again.

@rkolesnev
Copy link
Contributor

/sem-approve

@rkolesnev rkolesnev self-requested a review May 7, 2024 15:06
@rkolesnev rkolesnev merged commit dc0b921 into confluentinc:master May 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants