Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #787 for cannot close and exit properly when rebalancing storm #789

Merged
merged 4 commits into from
Jun 6, 2024
Merged

fix issue #787 for cannot close and exit properly when rebalancing storm #789

merged 4 commits into from
Jun 6, 2024

Conversation

sangreal
Copy link
Contributor

@sangreal sangreal commented Jun 5, 2024 •
edited
Loading

Description...
fix issue #787 for cannot close and exit properly when rebalancing storm.

Checklist

  • Documentation (if applicable)
  • Changelog

@sangreal sangreal requested a review from a team as a code owner June 5, 2024 02:53
@sangreal
Copy link
Contributor Author

sangreal commented Jun 5, 2024

I don't check if State is CLOSING or DRAINING is that it will deprive the interruption on waiting on mailbox queue.
Therefore I follow currentlyPollingWorkCompleteMailBox as flag to avoid to be interrupted while waiting submitted tasks to be executed.

rkolesnev
rkolesnev suggested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@rkolesnev rkolesnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added suggested changes to rename the variable and re-word the comments a bit.

...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java Outdated Show resolved Hide resolved
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java Outdated Show resolved Hide resolved
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java Outdated Show resolved Hide resolved
...src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java Outdated Show resolved Hide resolved
@rkolesnev
Copy link
Contributor

/sem-approve

@sangreal
Copy link
Contributor Author

sangreal commented Jun 5, 2024

@rkolesnev I have addressed your comments, please help check again. Thanks for the quick review.

@rkolesnev
Copy link
Contributor

/sem-approve

@rkolesnev rkolesnev merged commit ba169c1 into confluentinc:master Jun 6, 2024
2 checks passed
@rkolesnev rkolesnev mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkolesnev rkolesnev rkolesnev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sangreal @rkolesnev