Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick all commits from upstream v2.2.2 into 2.2.x #58

Merged
merged 21 commits into from
May 31, 2024

Conversation

sudeshwasnik
Copy link
Member

Cherry-pick all commits from upstream v2.2.2 into 2.2.x

List of commits : snowflakedb/snowflake-kafka-connector@v2.2.0...v2.2.2

Commands run :

  1. git checkout 2.2.x
  2. git checkout -b 2.2.x-release-2.2.2
  3. git cherry-pick 85b692c...3741498

@kapilchhajer
Copy link
Member

@sudeshwasnik I don't see this commit.
Screenshot 2024-05-31 at 12 38 26 PM

sfc-gh-mbobowski and others added 21 commits May 31, 2024 13:39
SNOW-979849

Add offset verification logic as part of channel open. We're verifying that the current start offset = previous end offset +1, if not true, then it potentially means missing or duplicate data. Note that there are some false positives that we can't avoid like when SMT is used, but this is good enough to do blast radius analysis for any corruption issue.
@sudeshwasnik sudeshwasnik force-pushed the 2.2.x-release-2.2.2 branch from 0e1abeb to 596e48f Compare May 31, 2024 08:11
Copy link
Member

@kapilchhajer kapilchhajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudeshwasnik sudeshwasnik merged commit bd07871 into 2.2.x May 31, 2024
@sudeshwasnik sudeshwasnik deleted the 2.2.x-release-2.2.2 branch May 31, 2024 12:23
sudeshwasnik added a commit that referenced this pull request May 31, 2024
sudeshwasnik added a commit that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.