Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIT-2476-fix - Update function fix #509

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalikconfluent commented Dec 5, 2024

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@tmalikconfluent tmalikconfluent marked this pull request as ready for review December 10, 2024 19:52
@tmalikconfluent tmalikconfluent requested a review from a team as a code owner December 10, 2024 19:52
Copy link
Contributor

@linouk23 linouk23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a minor comment.

@linouk23
Copy link
Contributor

Update: we ran the tests locally and it seems like there may be a bug as terraform apply gets stuck:

confluent_flink_statement.example: Still modifying... [id=env-mzqxx7/lfcp-2k5g3m/tf-2025-01-14-000225-76eea085-76dc-4edc-adb6-48af817f7566, 1m0s elapsed]
confluent_flink_statement.example: Still modifying... [id=env-mzqxx7/lfcp-2k5g3m/tf-2025-01-14-000225-76eea085-76dc-4edc-adb6-48af817f7566, 1m10s elapsed]
confluent_flink_statement.example: Still modifying... [id=env-mzqxx7/lfcp-2k5g3m/tf-2025-01-14-000225-76eea085-76dc-4edc-adb6-48af817f7566, 1m20s elapsed]
confluent_flink_statement.example: Still modifying... [id=env-mzqxx7/lfcp-2k5g3m/tf-2025-01-14-000225-76eea085-76dc-4edc-adb6-48af817f7566, 1m30s elapsed]
confluent_flink_statement.example: Still modifying... [id=env-mzqxx7/lfcp-2k5g3m/tf-2025-01-14-000225-76eea085-76dc-4edc-adb6-48af817f7566, 1m40s elapsed]

Most likely, the root cause is TF Provider tries to stop a statement (return flinkStatementStop(ctx, d, meta)) even for a paramPropertiesSensitive attribute update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants