Add Log Filter Options for Savon #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jheth Are you the main maintainer of the Soapforce gem? How do I get a review for my PR? Thanks! |
jheth
reviewed
Aug 15, 2018
soapforce.gemspec
Outdated
| @@ -21,6 +21,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_runtime_dependency "savon", ">= 2.3.0", '< 3.0.0' | |||
|
|
|||
| spec.add_development_dependency 'rspec', '>= 2.14.0', '< 4.0.0' | |||
| spec.add_development_dependency 'webmock', '>= 1.17.0', '< 2.0.0' | |||
| spec.add_development_dependency 'webmock', '2.3.2' | |||
There was a problem hiding this comment.
Why pin to a specific version? Can we do >= 2.3.2?
jheth
reviewed
Aug 15, 2018
| @@ -319,7 +319,7 @@ | |||
|
|
|||
| describe "#update" do | |||
| before(:each) do | |||
| @body = "<tns:update><tns:sObjects><ins0:type>Opportunity</ins0:type><ins0:Id>003ABCDE</ins0:Id><tns:Name>SOAPForce Opportunity</tns:Name><tns:CloseDate>2013-08-12</tns:CloseDate><tns:StageName>Closed Won</tns:StageName></tns:sObjects></tns:update>" | |||
| @body = "<tns:update><tns:sObjects><ins0:type>Opportunity</ins0:type><tns:Id>003ABCDE</tns:Id><tns:Name>SOAPForce Opportunity</tns:Name><tns:CloseDate>2013-08-12</tns:CloseDate><tns:StageName>Closed Won</tns:StageName></tns:sObjects></tns:update>" | |||
There was a problem hiding this comment.
I didn't expect the namespace to change. Any idea why it did?
There was a problem hiding this comment.
No, not really, but it looks like a Savon issue savonrb/savon#830
jheth
reviewed
Aug 15, 2018
spec/lib/client_spec.rb
Outdated
| @@ -18,7 +18,7 @@ | |||
| stub = stub_login_request({with_body: body}) | |||
| stub.to_return(:status => 200, :body => fixture("login_response")) #, :headers => {}) | |||
|
|
|||
| subject.login(username: 'testing', password: 'password_and_token') | |||
| subject.login(username: 'testing', password: 'password_and_token', filters: []) | |||
There was a problem hiding this comment.
Adding filters here doesn't look right. It's not used by the login method, it's only used from initialize.
|
@jheth Hi, any update on this? Thanks! |
|
Hey @lbblock2 , sorry for the delay. Forgot to click merge and then realized I don't have the right permissions. I've contacted the org to help me out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to include filters for logs to Savon, to take advantage of https://github.com/savonrb/savon/blob/e76ecc00b84b998b012ecc33b55ca1edd443ec55/lib/savon/log_message.rb#L7 and thereby allow us to filter out passwords (as in https://github.com/savonrb/savon/blob/e76ecc00b84b998b012ecc33b55ca1edd443ec55/spec/savon/log_message_spec.rb#L44)