Add absolute values and convert to Minion #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozgurakgun
reviewed
Jan 10, 2025
|
@ozgurakgun I have added a bug-fix for division domains to this commit. This fixes abs-03 giving different solutions with Oxide and Conjure Updated commit message:
|
ozgurakgun
reviewed
Jan 10, 2025
ozgurakgun
reviewed
Jan 10, 2025
conjure_oxide/tests/integration/basic/abs/04-bounds/input.eprime
Outdated
Show resolved
Hide resolved
ozgurakgun
approved these changes
Jan 10, 2025
niklasdewally
force-pushed
the
nik/pr/add-abs/01
branch
from
9a78d1e to
bc88505
Compare
Add support for absolute values, in particular: * Parsing from JSON. * The `Abs` expression variant. * The `FlatAbsEq` Minion constraint. * Flattening and conversion to Minion. As part of this change, a division domain bug is fixed. In our domain calculation we use truncating division, the default Rust integer division operator. However, the semantics of Essence Prime specify floor division. Truncating division has the effect of rounding towards 0. Truncating division does `-5 / 2 =-2` and `5/2 = 2`. However, we want `-5/2 = -3` and `5/2 = 2`. This caused the domains of variables containing negative divisions to sometimes be one too high. For abs-03, this caused Oxide to give different solutions than Conjure.
niklasdewally
force-pushed
the
nik/pr/add-abs/01
branch
from
bc88505 to
eaf65ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for absolute values, in particular:
Absexpression variant.FlatAbsEqMinion constraint.