Fix regression in how we handle solution copying #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameter files that had dashes (-) in the filename. Added a regression test case as well. Thanks @ott2 for reporting!
|
This seems to work now @ott2. I'll merge soon, but feel free to take a look at the diff before I do so? I might be missing something again... |
|
@ozgurakgun Not sure this is the precise same issue, but current head has this solution copying problem if one specifies a pathname for a parameter file that includes a directory separator: Edit: in case this has a different cause, have opened a new issue #578 about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression in how we handle solution copying. This only effected parameter files that had dashes (-) in the filename. Added a regression test case as well. Thanks @ott2 for reporting!