Make transitional classes obsolete

connamara · Nov 27, 2024 · 54555d4 · 54555d4
1 parent ac9a387
commit 54555d4
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 6 deletions.
diff --git a/Examples/Executor/Program.cs b/Examples/Executor/Program.cs
@@ -28,8 +28,12 @@ static void Main(string[] args)
                 SessionSettings settings = new SessionSettings(args[0]);
                 IApplication executorApp = new Executor();
                 IMessageStoreFactory storeFactory = new FileStoreFactory(settings);
-                var loggerFactory = new LoggerFactory([new ScreenLoggerProvider(settings)]);
-                // var loggerFactory = new LoggerFactory([new FileLogProvider(settings)]);
+                var loggerFactory = LoggerFactory.Create(builder =>
+                {
+                    builder.SetMinimumLevel(LogLevel.Trace);
+                    builder.AddProvider(new ScreenLoggerProvider(settings));
+                    builder.AddProvider(new FileLoggerProvider(settings));
+                });
                 ThreadedSocketAcceptor acceptor =
                     new ThreadedSocketAcceptor(executorApp, storeFactory, settings, loggerFactory);
                 HttpServer srv = new HttpServer(HttpServerPrefix, settings);

diff --git a/Examples/SimpleAcceptor/Program.cs b/Examples/SimpleAcceptor/Program.cs
@@ -31,7 +31,10 @@ static void Main(string[] args)
                 SessionSettings settings = new SessionSettings(args[0]);
                 IApplication app = new SimpleAcceptorApp();
                 IMessageStoreFactory storeFactory = new FileStoreFactory(settings);
-                var loggerFactory = new LoggerFactory([new FileLoggerProvider(settings)]);
+                var loggerFactory = LoggerFactory.Create(builder =>
+                {
+                    builder.AddProvider(new FileLoggerProvider(settings));
+                });
                 IAcceptor acceptor = new ThreadedSocketAcceptor(app, storeFactory, settings, loggerFactory);
 
                 acceptor.Start();

diff --git a/Examples/TradeClient/Program.cs b/Examples/TradeClient/Program.cs
@@ -32,8 +32,11 @@ static void Main(string[] args)
                 QuickFix.SessionSettings settings = new QuickFix.SessionSettings(file);
                 TradeClientApp application = new TradeClientApp();
                 IMessageStoreFactory storeFactory = new FileStoreFactory(settings);
-                var loggerFactory = new LoggerFactory([new ScreenLoggerProvider(settings)]);
-                // var loggerFactory = new LoggerFactory([new FileLogProvider(settings)]);
+                var loggerFactory = LoggerFactory.Create(builder =>
+                {
+                    builder.AddProvider(new ScreenLoggerProvider(settings));
+                    // builder.AddProvider(new FileLogProvider(settings));
+                });
                 QuickFix.Transport.SocketInitiator initiator = new QuickFix.Transport.SocketInitiator(application, storeFactory, settings, loggerFactory);
 
                 // this is a developer-test kludge.  do not emulate.

diff --git a/QuickFIXn/Logger/FileLoggerProvider.cs b/QuickFIXn/Logger/FileLoggerProvider.cs
@@ -5,6 +5,9 @@
 
 namespace QuickFix.Logger;
 
+[Obsolete("This class is provided to ease migration from the old logging system to Microsoft.Extensions.Logging." +
+          "It is an attempt to maintain the behavior of the previous FileLog and FileLogFactory while plugging into the Microsoft.Extensions.Logging ecosystem. " +
+          "Consider using the more robust logging options available in the .NET ecosystem, like the MS Console logging provider, Serilog and NLog.")]
 public class FileLoggerProvider : ILoggerProvider
 {
     private readonly SessionSettings _settings;

diff --git a/QuickFIXn/Logger/NullLoggerProvider.cs b/QuickFIXn/Logger/NullLoggerProvider.cs
@@ -1,7 +1,11 @@
-using Microsoft.Extensions.Logging;
+using System;
+using Microsoft.Extensions.Logging;
 
 namespace QuickFix.Logger;
 
+[Obsolete("This class is provided to ease migration from the old logging system to Microsoft.Extensions.Logging." +
+          "It is an attempt to maintain the behavior of the previous NullLog and NullLogFactory while plugging into the Microsoft.Extensions.Logging ecosystem. " +
+          "Consider using the more robust logging options available in the .NET ecosystem, like the MS Console logging provider, Serilog and NLog.")]
 public class NullLoggerProvider : ILoggerProvider
 {
     public void Dispose(){}

diff --git a/QuickFIXn/Logger/ScreenLoggerProvider.cs b/QuickFIXn/Logger/ScreenLoggerProvider.cs
@@ -4,6 +4,9 @@
 
 namespace QuickFix.Logger;
 
+[Obsolete("This class is provided to ease migration from the old logging system to Microsoft.Extensions.Logging." +
+          "It is an attempt to maintain the behavior of the previous ScreenLog and ScreenLogFactory while plugging into the Microsoft.Extensions.Logging ecosystem. " +
+          "Consider using the more robust logging options available in the .NET ecosystem, like the MS Console logging provider, Serilog and NLog.")]
 public class ScreenLoggerProvider : ILoggerProvider
 {
     private const string SCREEN_LOG_SHOW_INCOMING = "ScreenLogShowIncoming";