[Rebase 890] Fixed issue: throw IOException: The process cannot access the file 'xxxx\log\Non-Session-Log.messages.current.log' because it is being used by another process. #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xxx\log\Non-Session-Log.messages.current.log' because it is being used by another process.
…ssage value, the message value of the Exception should not be asserted, but rather the ErrorCode of the Exception.
…SessionLog instance has been released, there are no side effects even if the OnEvent function is called unexpectedly.
I accidentally introduced these problems in connamara#900. The problem only exhibited itself on Windows, argh
|
@VAllens Also-- let me know if/how you want your name to appear on https://quickfixengine.org/n/ |
Sure! You can list my name as [Allen Cai] on the site. |
|
Cool. The site will be updated after the next release (which I think will be January) |
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
[Rebase 890] Fixed issue: throw IOException: The process cannot access the file 'xxxx\log\Non-Session-Log.messages.current.log' because it is being used by another process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attn @VAllens -- (Thanks so much for your help with this! And I apologize for taking 2 months to get back to it.)
Rebase #890, which makes NonSessionLog implement IDisposable, which is then used to fix some IOException issues.
Then I made a few other fixes on top of that (see comments of #891 for that discussion). Verified on Windows that all tests pass and that the test suite finishes down cleanly.