Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SgExample Tweaks #341

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

SgExample Tweaks #341

wants to merge 2 commits into from

Conversation

bstaruk
Copy link
Contributor

@bstaruk bstaruk commented Feb 9, 2018

Description

This branch contains a couple small tweaks to the SgExample organism that @pgregorova requested a couple days ago:

  1. Reduce the horizontal padding for small devices from 3em to 2em
  2. Modify the dark background option to only affect the component, and not the entire example

Motivation and Context

These changes are purely aesthetic and it's possible that we may decide as a team that they are not desirable or necessary. I would take no offense to that!

It's worth noting that I left the "dark-background" class on the SgExample tag, instead of moving it to the component itself. The reason for this is to keep the JSX tidy (utilize the FC class stack to apply it) and to allow for overrides to other child elements in the future without making non-CSS code changes.

How Has This Been Tested?

This branch only contains a couple CSS tweaks so it should be very safe to merge into develop, should we choose to proceed with it.

Screenshots (if appropriate):

Old implementation
New implementation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@drolsen drolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any reservation around if the dark background encompasses the full example or not, but do approve the spacing updates.

@CSKingMartin I know this feature was your addition, did you want to alter this in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants