Add tests for connect error detail debug data #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
jhump
approved these changes
Sep 10, 2024
Signed-off-by: Timo Stamm <ts@timostamm.de>
Good call. Added in f028979. |
jhump
reviewed
Sep 11, 2024
| @@ -107,6 +107,73 @@ testCases: | |||
| error: | |||
| code: CODE_OUT_OF_RANGE | |||
| message: oops | |||
| - request: | |||
| # Clients must not depend on data in the "debug" key when deserializing details. | |||
| testName: error/disregard-detail-debug | |||
There was a problem hiding this comment.
I think the test cases are typically named in a way that describe the scenario, vs describing the implementation's expected behavior. How about invalid-details-debug instead of disregard-detail-debug? (Sorry I didn't mention this with previous remark.)
There was a problem hiding this comment.
👍 There are a couple of existing tests named "allow-unrecognized...". Doesn't seem worth renaming them, but renamed the new ones in 7a9e8c2.
There was a problem hiding this comment.
Ah, thanks for calling those out. I can sort those out in a separate PR.
Signed-off-by: Timo Stamm <ts@timostamm.de>
jhump
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect clients must not depend on data in the "debug" key when deserializing details from an Error or EndStreamResponse.
This PR adds a test where the "debug" key contains data that does not match the error detail, and is not a JSON object (see clarification regarding the property type here here).