-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Next.js v14 #1159
Conversation
962c9b1
to
75c7f71
Compare
@timostamm actually should we support 13 and 14? i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually should we support 13 and 14
Definitely.
Our README states:
It requires the Node.js server runtime, which is used by default when deploying to Vercel.
Can you verify that this is still true?
I found this in the docs. Not sure if this is what you're looking for: |
Signed-off-by: Steve Ayers <sayers@buf.build>
Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Steve Ayers <sayers@buf.build>
681cbf4
to
bb4f3f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you update the PR title and description to clarify this adds support for Next v14, and doesn't drop v13?
This upgrades
@connect-next
to add support for Next.js v14 as a peer dependency. Note that v13.x is still supported.This upgrade was tested in examples-es here to verify no issues.