Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Next.js v14 #1159

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add support for Next.js v14 #1159

merged 3 commits into from
Jul 30, 2024

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Jul 29, 2024

This upgrades @connect-next to add support for Next.js v14 as a peer dependency. Note that v13.x is still supported.

This upgrade was tested in examples-es here to verify no issues.

@smaye81
Copy link
Member Author

smaye81 commented Jul 29, 2024

@timostamm actually should we support 13 and 14? i.e. >=13.2.4 <15

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually should we support 13 and 14

Definitely.

Our README states:

It requires the Node.js server runtime, which is used by default when deploying to Vercel.

Can you verify that this is still true?

packages/connect-next/package.json Outdated Show resolved Hide resolved
@smaye81
Copy link
Member Author

smaye81 commented Jul 30, 2024

I found this in the docs. Not sure if this is what you're looking for:

image

smaye81 and others added 3 commits July 30, 2024 12:20
Signed-off-by: Steve Ayers <sayers@buf.build>
Signed-off-by: Steve Ayers <sayers@buf.build>
Co-authored-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Steve Ayers <sayers@buf.build>
@smaye81 smaye81 force-pushed the sayers/upgrade_nextjs_deps branch from 681cbf4 to bb4f3f1 Compare July 30, 2024 16:20
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you update the PR title and description to clarify this adds support for Next v14, and doesn't drop v13?

@smaye81 smaye81 merged commit 00ca04b into main Jul 30, 2024
20 checks passed
@smaye81 smaye81 deleted the sayers/upgrade_nextjs_deps branch July 30, 2024 16:29
@timostamm timostamm changed the title Upgrade @connect-next to NextJS v14 Add support for Next.js v14 Sep 10, 2024
@timostamm timostamm mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants