Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky decompression error code #1204

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

timostamm
Copy link
Member

@timostamm timostamm commented Sep 2, 2024

In the recent versions v20.17.0 and v16.20.2, the zip module from Node.js uses different error codes for brotli decompression. This updates the code to handle both old error codes, and new.

Signed-off-by: Timo Stamm <ts@timostamm.de>
@timostamm timostamm force-pushed the tstamm/fix-flaky-decompression-error branch from bf9e575 to 0b33aea Compare September 2, 2024 13:37
@smaye81
Copy link
Member

smaye81 commented Sep 2, 2024

Ha nice! One small thing - the description mentions the same version. Not sure which one is incorrect.

@timostamm timostamm merged commit 4422dda into main Sep 3, 2024
21 checks passed
@timostamm timostamm deleted the tstamm/fix-flaky-decompression-error branch September 3, 2024 07:12
@timostamm timostamm mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants