-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration cli #769
Add migration cli #769
Conversation
Add comment to fix lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising, now we just have to sort out the details.
Blocking on jest, we already have enough dependencies. I'm okay with replacing it later, when we know better what needs testing.
...onnect-migrate/src/transforms/__testfixtures__/modify-imports/sub-directory-imports.input.ts
Outdated
Show resolved
Hide resolved
...nnect-migrate/src/transforms/__testfixtures__/modify-imports/sub-directory-imports.output.ts
Outdated
Show resolved
Hide resolved
packages/connect-migrate/src/transforms/__testfixtures__/modify-imports/simple.input.ts
Outdated
Show resolved
Hide resolved
@timostamm all great points, i had started on this tool separate from connect-es, so i'll migrate the packages/testing to something more akin to what's in connectrpc already. This was mostly just porting things over as is. I'll tune it up. |
- Added support to detect quote style
# Conflicts: # package-lock.json
Co-authored-by: Timo Stamm <ts@timostamm.de>
Co-authored-by: Timo Stamm <ts@timostamm.de>
Co-authored-by: Timo Stamm <ts@timostamm.de>
Co-authored-by: Timo Stamm <ts@timostamm.de>
Add comment to readme to allow more customization.
@timostamm I've fixed the issue with parsing you had with the |
Created a CLI that migrates from old packages to new.