Add context values to clients

[srikrsna-buf]

Add context values to clients. This adds support for ContextValues in clients via CallOptions and Interceptors:

import { ElizaService } from "gen/...";
import { createPromiseClient } from "@connectrpc/connect";
import transport from "./transport.js";
import kUser from "user-context.js";

const client = createPromiseClient(ElizeService, trasport);

await client.say({ sentence: "Hi" }, { values: createContextValues().set(kUser, { ... }) });

Which can be accessed in an interceptor:

const tokenInterceptor = (next) => {
    return (req) => {
           req.header.set("Authorization", `Bearer ${req.values.get(kUser).token}`);
           return next(req);
    };
};

[paul-sachs]

Love the simplicity. My one tiny nitpick is that the key on the Request object is just values, which on first read feels like it's some dictionary representation of the content of the request. Perhaps calling it context instead? I guess values just feels a touch generic.

[srikrsna-buf]

Perhaps calling it context instead? I guess values just feels a touch generic.

I also prefer that, but a potential problem I see is that when we implement server-side interceptors, one of the possible designs is to just reuse the interceptor types that we use on the client. context could be confusing to users as they might expect HandlerContext.

If an alternate design for interceptors is possible then I don't see a problem with naming this context. My efforts to get TS to work have been unsuccessful so far I tried a couple of designs and the ones we have for the client seem the most promising but nevertheless we can wait until at least we finalize the design

[timostamm]

It's certainly a bit more verbose, but what about contextValues for the option name? It mirrors the name in #835.

[srikrsna-buf]

I changed the name to contextValues I also updated UniversalServerRequest. The only place it is called values is on HandlerContext.