Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce experimental ConnectRouter.rpc overload to not require full ServiceType #925

Merged
merged 15 commits into from
Nov 27, 2023

Conversation

paul-sachs
Copy link
Contributor

@paul-sachs paul-sachs commented Nov 24, 2023

Partly copied from bufbuild/protobuf-es#594:

ConnectRouter.rpc overload that doesn't require the full service is easier to use for one off methods that don't require an entire service to be defined.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(Ran browserstack test locally)

@timostamm timostamm merged commit b4863fb into connectrpc:main Nov 27, 2023
5 of 6 checks passed
@smaye81 smaye81 mentioned this pull request Dec 1, 2023
@timostamm timostamm changed the title Introduce ConnectRouter.rpc overload to not require full ServiceType Introduce experimental ConnectRouter.rpc overload to not require full ServiceType Dec 1, 2023
@smaye81 smaye81 mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants