add support for ReadMaxBytes option #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
force-pushed
the
pkw/read-max-bytes
branch
from
f4d6b71 to
aff2dcf
Compare
Update connect-go to allow configuring a ReadMaxBytes option. This is useful to avoid excessive memory/cpu usage when dealing with very large messages.
pkwarren
force-pushed
the
pkw/read-max-bytes
branch
from
64ecc86 to
d20f50a
Compare
|
Awesome, will try to review it tonight! @mattrobenolt FYI this should land soon. |
akshayjshah
approved these changes
Jul 7, 2022
| if err != nil { | ||
| return errorf(CodeInvalidArgument, "message is larger than configured max %d - unable to determine message size: %w", readMaxBytes, err) | ||
| } | ||
| return errorf(CodeInvalidArgument, "message size %d is larger than configured max %d", bytesRead+discardedBytes, readMaxBytes) |
There was a problem hiding this comment.
Nice, love this! Good reason not to use discard.
| t.Helper() | ||
| t.Run("equal_read_max", func(t *testing.T) { | ||
| t.Parallel() | ||
| // Serializes to exactly readMaxBytes (1024) - no errors expected |
There was a problem hiding this comment.
Excellent, glad you're testing this - looking at your code, I bet my previous implementation had an off-by-one error.
|
🤦🏽♂️ I didn't review this carefully enough. Per the gRPC specification, we should be using FYI, @mattrobenolt - there's a small change to this behavior incoming. |
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Update connect-go to allow configuring a ReadMaxBytes option. This is useful to avoid excessive memory/cpu usage when dealing with very large messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update connect-go to allow configuring a ReadMaxBytes option. This is
useful to avoid excessive memory/cpu usage when dealing with very large
messages.