Match Content-Type charset case-insensitively #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayjshah
approved these changes
Jan 26, 2023
akshayjshah
changed the title
renovate bot
referenced
this pull request
in open-feature/flagd
Jan 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bufbuild/connect-go](https://togithub.com/bufbuild/connect-go) | require | minor | `v1.4.1` -> `v1.5.0` | --- ### Release Notes <details> <summary>bufbuild/connect-go</summary> ### [`v1.5.0`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.5.0) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.4.1...v1.5.0) #### What's Changed ##### Enhancements - Add NewWireError for propagating partial stream failures by [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/437](https://togithub.com/bufbuild/connect-go/pull/437) ##### Bugfixes - Match Content-Type charset case-insensitively by [@​ichizero](https://togithub.com/ichizero) in [https://github.com/bufbuild/connect-go/pull/440](https://togithub.com/bufbuild/connect-go/pull/440) #### New Contributors - [@​ichizero](https://togithub.com/ichizero) made their first contribution in [https://github.com/bufbuild/connect-go/pull/440](https://togithub.com/bufbuild/connect-go/pull/440) **Full Changelog**: bufbuild/connect-go@v1.4.1...v1.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
](https://renovatebot.com){kind=link}
The connect handler returns http.StatusUnsupportedMediaType when a request has a `Content-Type: application/json; charset=UTF-8` header. However, according to [RFC 9110 Section 8.3.2]( https://httpwg.org/specs/rfc9110.html#rfc.section.8.3.2), the charset parameter value should be treated as case-insensitive. In this PR, I have modified the charset parameter value for user requests and acceptable content types of handlers to all be handled in lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connect handler returns http.StatusUnsupportedMediaType when a request has a
Content-Type: application/json; charset=UTF-8header. However, according to RFC 9110 Section 8.3.2, the charset parameter value should be treated as case-insensitive.In this PR, I have modified the charset parameter value for user requests and acceptable content types of handlers to all be handled in lowercase.