Connect Get: Add serverside compression support #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchadwick-buf
changed the title
akshayjshah
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
LGTM.
I don't think we need to do anything for the accept header (at least, not in this stack of PRs). Like gRPC, the Connect protocol doesn't really support content-type negotiation - the response always uses the same encoding as the request. If we want to change that, let's do it in a separate stack of PRs and address both the POST and GET paths.
Does that make sense? Or were you thinking of doing something else with Accept?
|
Oops, I forgot to merge this. No, I think for now we don't really need to worry about Accept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing from the original server PR.
Q: Should we do anything for the accept header?