Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect HTTP Get support #478

Merged
merged 13 commits into from
Apr 6, 2023
Merged

Connect HTTP Get support #478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5caa69e
Add stable codec interface and implementations (#460)
jchadwick-buf Feb 21, 2023
af10789
Connect GET support (server) (#466)
jchadwick-buf Mar 6, 2023
30fd7ec
Connect GET support (client) (#473)
jchadwick-buf Mar 16, 2023
e39b053
Connect Get: Add serverside compression support (#475)
jchadwick-buf Mar 20, 2023
439ad37
Rewrite HTTP Get options (#482)
jchadwick-buf Mar 30, 2023
be81220
Merge branch 'main' of https://github.com/bufbuild/connect-go into ge…
jchadwick-buf Mar 30, 2023
c2015a9
Prevent unnecessary alloc during JSON compaction
jchadwick-buf Mar 30, 2023
da71eca
Improve HTTP Get encoding errors
jchadwick-buf Mar 31, 2023
5b79b76
Add clarification to CanHandlePayload comment.
jchadwick-buf Mar 31, 2023
89053c9
Unexport WithHTTPGetMaxURLSize.
jchadwick-buf Apr 3, 2023
9119519
Re-add test for Get fallback
jchadwick-buf Apr 4, 2023
d2b038d
Move unexported identifier after exported
akshayjshah Apr 6, 2023
8d0fa9b
Remove reference to Connect being POST-only
akshayjshah Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions client_ext_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,6 @@ func TestClientPeer(t *testing.T) {
t.Parallel()
run(t,
connect.WithHTTPGet(),
connect.WithHTTPGetMaxURLSize(256, false),
connect.WithSendGzip(),
)
})
t.Run("connect+get fallback", func(t *testing.T) {
t.Parallel()
run(t,
connect.WithHTTPGet(),
connect.WithHTTPGetMaxURLSize(1, true),
jchadwick-buf marked this conversation as resolved.
Show resolved Hide resolved
connect.WithSendGzip(),
)
})
Expand Down
8 changes: 6 additions & 2 deletions option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ func WithHTTPGet() ClientOption {
return &enableGet{}
}

// WithHTTPGetMaxURLSize sets the maximum allowable URL length for GET requests
// withHTTPGetMaxURLSize sets the maximum allowable URL length for GET requests
// made using the Connect protocol. It has no effect on gRPC or gRPC-Web
// clients, since those protocols are POST-only.
//
Expand All @@ -278,10 +278,14 @@ func WithHTTPGet() ClientOption {
//
// By default, Connect-protocol clients with GET requests enabled may send a
// URL of any size.
func WithHTTPGetMaxURLSize(bytes int, fallback bool) ClientOption {
func withHTTPGetMaxURLSize(bytes int, fallback bool) ClientOption {
return &getURLMaxBytes{Max: bytes, Fallback: fallback}
}

// TODO(jchadwick-buf): Remove this once we've determined whether this option
// should be exported or removed.
var _ = withHTTPGetMaxURLSize(0, false)
jchadwick-buf marked this conversation as resolved.
Show resolved Hide resolved

// WithInterceptors configures a client or handler's interceptor stack. Repeated
// WithInterceptors options are applied in order, so
//
Expand Down