Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce scope of err var in response content-type checks #681

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Reduce scope of err var in response content-type checks #681

merged 1 commit into from
Feb 8, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Feb 8, 2024 •
edited
Loading

This also formats the grpc version of the check so it is consistent with the other two.

Addresses comment in prior PR: #679 (comment)

akshayjshah
akshayjshah approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jhump jhump merged commit cc86f64 into main Feb 8, 2024
13 checks passed
@jhump jhump deleted the jh/reduce-scope-of-err-var branch February 8, 2024 21:38
@jhump jhump added the ignore-for-release Exclude from release notes label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

Assignees
No one assigned
Labels
ignore-for-release Exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhump @akshayjshah