Add additional conformance streaming tests #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a server streaming successful test case and a ping/pong test case for verifying bidirectional streams.
pkwarren
force-pushed
the
pkw/additional-conformance-tests
branch
from
c0cefb4
to
7675780
Compare
pkwarren
commented
Sep 22, 2023
| @@ -775,7 +806,7 @@ class Conformance( | |||
| countDownLatch.countDown() | |||
| } | |||
| } | |||
| countDownLatch.await(5, TimeUnit.MINUTES) | |||
There was a problem hiding this comment.
Had set this higher while debugging - can revert back to more reasonable wait times.
rebello95
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a server streaming successful test case and a ping/pong test case for verifying bidirectional streams.