Implement unary operations in conformance client #195
Conversation
| @mkdir -p $(dir $@) | ||
| @touch $@ |
There was a problem hiding this comment.
This seemed weird that it would create an empty placeholder zip file. So I tweaked this so that the artifact it creates is the actual downloaded ZIP file.
I also added a distinct target for the .tmp/bin/protoc binary itself because, TBH, I found it very confusing that the $(PROTOC) target was actually referencing a bogus ZIP file.
There was a problem hiding this comment.
At some point I'd love to move all of this into the gradle build so we only have to maintain a single build system but this is a nice improvement.
…o that unary conformance tests are run during CI
| @mkdir -p $(dir $@) | ||
| @touch $@ |
There was a problem hiding this comment.
At some point I'd love to move all of this into the gradle build so we only have to maintain a single build system but this is a nice improvement.
| } | ||
| } | ||
| } | ||
| return ClientArgs(invokeStyle, verbosity) |
There was a problem hiding this comment.
This works for now but in the future I've had good success with https://args4j.kohsuke.org/ if we need more complexity here.
There was a problem hiding this comment.
Yeah, I've used a similar library, JCommander. I actually briefly looked into Clickt, which seems to be the most popular library for Kotlin command-line apps. But I had an issue with it (likely something quirky in the IDE, though I did update the project after adding a dep in gradle, but it still wouldn't work), so I decided to punt on pulling in a dep for this, since this logic is so simple 🤷
| ) { | ||
| fun run(input: InputStream, output: OutputStream, client: Client) = runBlocking { | ||
| // TODO: issue RPCs in parallel | ||
| while (true) { | ||
| var result: ClientCompatResponse.Result | ||
| val req = readRequest(input) ?: return@runBlocking // end of stream | ||
| if (verbosity > 0) { |
There was a problem hiding this comment.
Another option for more debugging might be to configure the okhttp logging interceptor (perhaps at higher verbosity?).
There was a problem hiding this comment.
Ack. That would likely be much more verbose than this. I haven't needed that sort of output so far, but it does seem like a potentially useful idea.
This also adds support for other command-line args, to enable verbose tracing output (which was handy for troubleshooting stuff).
Other repos use the make target
runconformance, but this repo was usingconformancerun, so I changed it. That target still runs the old cross test stuff, but it also now runs these new unary conformance test cases. The config file is what indicates unary-only. The "known failing" file is because the assertions in the test runner for Connect GET requests are too strict -- AFAICT, this client now passes those tests. The only failing assertion is about themessagequery param that the server gets because it is expecting the encoding in a particular way, but that is not necessary (but requires a change in the test runner to relax the assertion).The
Makefiledownloads the conformance test runner in the same fashion as it downloadsprotoc.