Remove "module" export condition to prevent confusion with webpack #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/fix-406
branch
from
71865f3
to
41b4fde
Compare
|
I guess we could also move module down below and do something like: "exports": {
".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.cjs",
"module": "./dist/esm/index.js"
}
},But i'd rather remove it entirely and not have to worry about it. Removing is also brings this package into line with the other connect packages. |
timostamm
approved these changes
Sep 9, 2024
Merged
paul-sachs
added a commit
that referenced
this pull request
Sep 9, 2024
## What's Changed * Remove "module" export condition to prevent confusion with webpack by @paul-sachs in #407 **Full Changelog**: v1.4.1...v1.4.2 Signed-off-by: Paul Sachs <psachs@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "module" export condition is overriding the other conditions in webpack, so a cjs file importing connect-query will resolve to the esm module instead.
Fixes #406