-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connect-node interceptor docs. #128
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but the example for context values is not straight-forward to follow (see comments below), and we need to make sure that the concepts of interceptors, context, context values and keys are all easily discoverable and mentioned at the relevant places.
In Node.js / Server Plugins / Common options, we need to add the new interceptors
option, and link to the new Interceptors page for details.
On the same page, we also need to document the option contextValues
for each of the server plugins, and also link to the new page.
In Web / Interceptors, we also need a sub-section for context values, and we need to document document CallOption.contextValues
there.
Co-authored-by: Timo Stamm <ts@timostamm.de>
Add connect-node interceptor documentation. Will merge after we release.