Skip to content

Commit

Permalink
Update EIP-1271: Update eip-1271.md (ethereum#7447)
Browse files Browse the repository at this point in the history
Update eip-1271.md

Small spelling correction.
  • Loading branch information
Zartaj0 authored and just-a-node committed Feb 17, 2024
1 parent 7fa7007 commit c3625be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion EIPS/eip-1271.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ This function should be implemented by contracts which desire to sign messages (
## Rationale
We believe the name of the proposed function to be appropriate considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract. Hence, a signed action message is only valid when the signer is authorized to perform a given action on the behalf of a smart wallet.
Two arguments are provided for simplicity of separating the hash signed from the signature. A bytes32 hash is used instead of the unhashed message for simplicy, since contracts could expect a certain hashing function that is not standard, such as with [EIP-712](./eip-712.md).
Two arguments are provided for simplicity of separating the hash signed from the signature. A bytes32 hash is used instead of the unhashed message for simplicity, since contracts could expect a certain hashing function that is not standard, such as with [EIP-712](./eip-712.md).
`isValidSignature()` should not be able to modify states in order to prevent `GasToken` minting or similar attack vectors. Again, this is to simplify the implementation surface of the function for better standardization and to allow off-chain contract queries.
Expand Down

0 comments on commit c3625be

Please sign in to comment.