Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[client, test-runner] Promises not properly rejecting #741

Closed
LayneHaber opened this issue Jan 15, 2020 · 2 comments
Closed

[client, test-runner] Promises not properly rejecting #741

LayneHaber opened this issue Jan 15, 2020 · 2 comments
Assignees
@LayneHaber
Labels
Needs Triage Needs to be looked at and prioritized.

Comments

@LayneHaber
Copy link
Contributor

Describe the bug
Client isn't properly rejecting promises when the REJECT_INSTALL_EVENT is caught.

Seems likely that the event is thrown before the promise is created.

To Reproduce
Run this test
@LayneHaber LayneHaber added the Needs Triage Needs to be looked at and prioritized. label Jan 15, 2020
@LayneHaber LayneHaber self-assigned this Jan 15, 2020
This was referenced Jan 15, 2020
Merged
Merged
@ArjunBhuptani ArjunBhuptani mentioned this issue Jan 16, 2020
Closed
@ArjunBhuptani
Copy link
Member

Duplicate of #700. Closing the older issue

@LayneHaber
Copy link
Contributor Author

Should be closed with #736

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LayneHaber LayneHaber

Labels
Needs Triage Needs to be looked at and prioritized.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LayneHaber @ArjunBhuptani