Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

715 async transfer easy cases #733

Merged
merged 24 commits into from
Jan 15, 2020
Merged

Conversation

LayneHaber
Copy link
Contributor

@LayneHaber LayneHaber commented Jan 14, 2020

Fixes #715

Skipping a test, issue opened #741

@todo-tracker
Copy link

todo-tracker bot commented Jan 14, 2020

Hey, LayneHaber

We noticed you made changes to a file with a TODO on it.
These are set to make sure potential Technical Debt doesn't get forgotten.
While you're here take a shot at turning a listed TODO into a TODONE!

Id Name File Priority
64 expose remove listener modules/node/src/transfer/transfer.service.ts Normal
66 determine virtual app in a more resilient way modules/client/src/listener.ts Normal
70 make this actually activate wallet connect cypress/tests/utils.js Normal
71 merge: modules/client/src/node.ts Normal
78 why is it sometimes data vs data.data? modules/client/src/controllers/AbstractController.ts Normal
83 should add once to top level client modules/test-runner/src/util/helpers/fundChannel.ts Normal
84 Currently, this test always fails because when promise is never rejected when modules/test-runner/src/swap/swap.test.ts Normal
85 events for withdrawal commitments! issue 698 modules/test-runner/src/withdraw/withdraw.test.ts Normal

button

@LayneHaber LayneHaber marked this pull request as ready for review January 15, 2020 19:05
Copy link
Contributor

@pedrouid pedrouid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LayneHaber LayneHaber merged commit 6939649 into staging Jan 15, 2020
@LayneHaber LayneHaber deleted the 715-async-transfer-easy-cases branch January 15, 2020 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-runner] Async transfer low-hanging fruit tests
2 participants