fix: removing optimistic mode guard from send (#30)

connext · Oct 4, 2023 · 10e7591 · 10e7591
1 parent f9eeab7
commit 10e7591
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/packages/deployments/contracts/contracts/messaging/connectors/SpokeConnector.sol b/packages/deployments/contracts/contracts/messaging/connectors/SpokeConnector.sol
@@ -530,7 +530,6 @@ abstract contract SpokeConnector is Connector, ConnectorManager, WatcherClient,
    * @param _encodedData Data needed to send crosschain message by associated amb
    */
   function send(bytes memory _encodedData) external payable whenNotPaused rateLimited {
-    if (optimisticMode) revert SpokeConnector_send__OptimisticModeOn();
     bytes32 root = MERKLE.root();
     require(sentMessageRoots[root] == false, "root already sent");
     // mark as sent

diff --git a/packages/deployments/contracts/contracts_forge/messaging/connectors/SpokeConnector.t.sol b/packages/deployments/contracts/contracts_forge/messaging/connectors/SpokeConnector.t.sol
@@ -151,13 +151,6 @@ contract SpokeConnector_General is Base {
     spokeConnector.send(abi.encode(""));
   }
 
-  function test_SpokeConnector__send_failsIfOptimisticModeOn() public {
-    MockSpokeConnector(payable(address(spokeConnector))).setOptimisticMode(true);
-
-    vm.expectRevert(SpokeConnector.SpokeConnector_send__OptimisticModeOn.selector);
-    spokeConnector.send(abi.encode(""));
-  }
-
   function test_SpokeConnector__send_failsIfRootAlreadySent() public {
     bytes32 root = bytes32(bytes("test123"));
     vm.mockCall(address(_merkle), abi.encodeWithSelector(MerkleTreeManager.root.selector), abi.encode(root));