Event signatures #15
Merged
Event signatures #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build broken because subgraph event signature changed, not sure how to fix this. Can we document it somewhere? |
rhlsthrm
approved these changes
Jul 7, 2021
| // for tx | ||
| if (toSend > 0) { | ||
| try | ||
| IMultisendInterpreter(iMultisend).addFunds{ value: LibAsset.isEther(txData.receivingAssetId) ? toSend : 0}( |
There was a problem hiding this comment.
We should change the name since it isn't MultiSend anymore.
| @@ -370,7 +371,7 @@ contract TransactionManager is ReentrancyGuard, ITransactionManager { | |||
| } | |||
|
|
|||
| // Handle receiver chain external calls if needed | |||
| if (txData.callDataHash == keccak256(new bytes(0))) { | |||
| if (txData.callTo == address(0)) { | |||
There was a problem hiding this comment.
We should change the name of callTo to be like fulfillHelperAddress or something more descriptive.
sanchaymittal
pushed a commit
that referenced
this pull request
Oct 18, 2023
* feat: removing lint (#10) * feat: root manager new variables (#8) * feat: adding new variables (#7) * refactor: root manager finalize function (#11) * refactor: root manager dequeue function (#15) * feat: adding optimistic mode to spoke (#12) * refactor: unify propagate * refactor: remove deprecated variable (#18) * feat: introduce last count check again (#20) * feat:optimistic mode guards (#19) * feat: guard propagation of root zero (#21) * feat: changing constructor params to struct (#23) * feat: added guard for pause to op functions (#25) * feat: adding whenNotPaused modifier to propose and finalize (#24) * chore: remove unnecesary setup functions on tests (#26) * fix: event natspec (#28) * refactor: remove lastCountBeforeOpMode variable (#29) * fix: natspec (#31) * fix: removing optimistic mode guard from send (#30) * feat: agg root direct save on hub spoke * feat: adding natspec * fix: typo * test: convention fixes * docs: natspec typo * docs: natspect typos * refactor: mainnet spoke imports * feat: saveAggregateRoot delentes pending root if exists * test: adding pending root deletion test * chore: root manager tests comments * feat: dispute blocks constructor check [L-1] (#35) * feat: fixing comment [Q-4] (#38) * feat: removing unused events and errors [Q-2] (#39) * feat: unifying save aggregate root events [Q-3] (#40) * feat: delete pending root on propose (#34) * feat: external for public [Q-1] (#36) --------- Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: 0xng <ng@defi.sucks>
preethamr
pushed a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following position-indexed fields to the
Transaction*events:This is done to make it easier to filter using the ethers.js
QueryFilter.Should not be merged until #14 is merged