This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Crosschain transfer #658
Draft
Crosschain transfer #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayneHaber
commented
Jun 16, 2021
modules/contracts/src.sol/transferDefinitions/CrosschainTransfer.sol
Outdated
Show resolved
Hide resolved
modules/contracts/src.sol/transferDefinitions/CrosschainTransfer.sol
Outdated
Show resolved
Hide resolved
Comment on lines
+91
to
+92
| return true; | ||
| } |
There was a problem hiding this comment.
Things that are not yet validated in the state:
respondercallTocallDatabalance.to
These are probably all okay, but this means that anything could be put into these values and a transfer could be created that is potentially unresolvable (i.e. what if responder isn't actually a proper address?)
Comment on lines
114
to
118
| // Transfer must have two valid parties. | ||
| require( | ||
| state.initiator != address(0) && state.responder != address(0), | ||
| "CrosschainTransfer: EMPTY_SIGNERS" | ||
| ); |
There was a problem hiding this comment.
This should be in the create
modules/contracts/src.sol/transferDefinitions/CrosschainTransfer.sol
Outdated
Show resolved
Hide resolved
modules/contracts/src.sol/transferDefinitions/CrosschainTransfer.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
The Solution
TODO before merging: