Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering over an icon shows it's name #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hovering over an icon shows it's name #126

wants to merge 1 commit into from

Conversation

jacksarick
Copy link

To more easily find the class name of an icon, you can now hover over it, and it will be displayed. I understand that this doesn't strictly follow the guidelines for contributing, but I figured it was small enough that it's OK. If not, sorry.

To more easily find the class name of an icon, you can now hover over it, and it will be displayed.
@webdevbrian
Copy link

Can't people who want to find the class name just inspect it through the debug tools? Why add the class name to the title text indefinitely? If anything, you could omit the icon- in front of the names, and from there just have the regular icon name show up.

I just don't see how this is something that should be merged in?

@RamiAwar
Copy link

Though this would be useful for the getting started page on the website, not the actual library. Less troublesome for developers to go into their dev tools and find the name themselves, they could just hover instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants