review feedback

conorbros · Aug 1, 2023 · 532ee79 · 532ee79
1 parent e9941dd
commit 532ee79
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/shotover-proxy/tests/cassandra_int_tests/mod.rs b/shotover-proxy/tests/cassandra_int_tests/mod.rs
@@ -655,7 +655,7 @@ async fn request_throttling(#[case] driver: CassandraDriver) {
 
  tokio::time::sleep(std::time::Duration::from_secs(1)).await; // sleep to reset the window
 
- shotover.shutdown_and_then_consume_events(&[]).await;
+ shotover.shutdown_and_then_consume_events(&[EventMatcher::new().with_level(Level::Warn).with_target("shotover::transforms::throttling").with_message(r#"A message was received that could never have been successfully delivered since it contains more sub messages than can ever be allowed through via the `RequestThrottling` transforms `max_requests_per_second` configuration."#)]).await;
 }
 
 #[cfg(feature = "alpha-transforms")]

diff --git a/shotover/src/transforms/throttling.rs b/shotover/src/transforms/throttling.rs
@@ -76,8 +76,8 @@ impl Transform for RequestThrottling {
  let message = requests_wrapper.requests.remove(i);
  Some((message, i))
  }
- Err(e) => {
- tracing::info!("{e}");
+ Err(_) => {
+ tracing::warn!("A message was received that could never have been successfully delivered since it contains more sub messages than can ever be allowed through via the `RequestThrottling` transforms `max_requests_per_second` configuration.");
  let message = requests_wrapper.requests.remove(i);
  Some((message, i))
  }