Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor views.py and other modules to OOP struct #29

Closed
conorheffron opened this issue Sep 11, 2024 · 1 comment · Fixed by #44
Closed

Refactor views.py and other modules to OOP struct #29

conorheffron opened this issue Sep 11, 2024 · 1 comment · Fixed by #44
Assignees
@conorheffron
Labels
ref-des Refactoring & Design Pattern Tasks

Comments

@conorheffron
Copy link
Owner

No description provided.

@conorheffron conorheffron added the ref-des Refactoring & Design Pattern Tasks label Sep 11, 2024
@conorheffron conorheffron self-assigned this Sep 11, 2024
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Refactor views.py and other modules to OOP struct
f3674eb
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Extract handler class from Views
372ec59
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Update bookings table data with heading
9777a81
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Explicit type handling for views & handler modules
525b791 
Fix some pylint issues
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Upgrade requirements.txt
9877565
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Fix lint issues
9d52338
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Refactor views.py and other modules to OOP struct (#44)
f3eb150 
* #29 Refactor views.py and other modules to OOP struct

* #42 Add placeholder text for reservation form & style input width to be consistent

- [] Update forms.py

* #29 Extract handler class from Views

* #29 Update bookings table data with heading

* #29 Explicit type handling for views & handler modules

Fix some pylint issues

* #29 Upgrade requirements.txt

* #29 Fix lint issues
@conorheffron conorheffron linked a pull request Sep 18, 2024 that will close this issue
#29 Refactor views.py and other modules to OOP struct #44
Merged
@conorheffron
Copy link
Owner Author

merged/deployed

conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Update Pipfile
6bc8672
conorheffron added a commit that referenced this issue Sep 18, 2024
@conorheffron
#29 Increase test coverage for views, handler (#45)
f8cdd46 
* #29 Update Pipfile

* #28 Update test.py

- [x] Test cases for views
- [x] Test case for 404 / page not found handler

* #28 Update test.py

- [x] Adding test case for invalid date format when calling bookings_by_date method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorheffron conorheffron

Labels
ref-des Refactoring & Design Pattern Tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#29 Refactor views.py and other modules to OOP struct conorheffron/booking-sys
1 participant
@conorheffron