Add spotify_artist data source and add functionality to spotify_album #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 71.60% 70.34% -1.26%
==========================================
Files 9 10 +1
Lines 493 553 +60
==========================================
+ Hits 353 389 +36
- Misses 97 119 +22
- Partials 43 45 +2
Continue to review full report at Codecov.
|
Comment on lines
+42
to
+53
| "tracks": { | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Description: "The spotify IDs of the tracks", | ||
| }, | ||
| "track_names": { | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Description: "The names of the tracks", | ||
| }, |
There was a problem hiding this comment.
Maybe instead of having 2 lists of strings, we could have a complex list
Suggested change
| "tracks": { | |
| Type: schema.TypeList, | |
| Computed: true, | |
| Elem: &schema.Schema{Type: schema.TypeString}, | |
| Description: "The spotify IDs of the tracks", | |
| }, | |
| "track_names": { | |
| Type: schema.TypeList, | |
| Computed: true, | |
| Elem: &schema.Schema{Type: schema.TypeString}, | |
| Description: "The names of the tracks", | |
| }, | |
| "tracks": { | |
| Type: schema.TypeList, | |
| Computed: true, | |
| Elem: &schema.Resource{ | |
| Schema: map[string]*schema.Schema{ | |
| "name": { | |
| Type: schema.TypeString, | |
| Description: "The name of the track", | |
| }, | |
| "id": { | |
| Type: schema.TypeString, | |
| Description: "The Spotify ID of the track", | |
| }, | |
| }, | |
| Description: "The tracks of the album", | |
| }, | |
| } |
There was a problem hiding this comment.
You can still get the individual items using splat expressions, so instead of data.spotify_album.foo.track_names it would become data.spotify_album.foo.tracks[*].name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few additions and improvements,
spotify_artistdata source to query artist ID/URL and retrievenamespotify_albumto have additionaltracksandtrack_namesdataExample of new data sources in-use: https://github.com/ecliptik/minidisc-playlist