This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
force-pushed
the
fm-99-eth-methods-3
branch
from
June 16, 2023 14:27
6a52f37
to
3a4832b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of consensus-shipyard/ipc#342
This PR carries on from #119 by creating a transaction to transfer tokens between two Ethereum accounts. The only method implemented is
eth_sendRawTransaction
. The tests use aWallet
from theethers
library to sign transactions.The API does not work with regular accounts, so the smoke-test setup creates two new accounts:
emily
anderic
.Because consensus-shipyard/ipc#336 is not implemented on the Application side yet, the PR disables signature checking for delegated addresses.
Follow up
The next PRs will continue building out new methods, as well as utilise sending raw transactions more: