Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

FM-99: Ethereum API methods (Part 3) #124

Merged
merged 18 commits into from
Jun 20, 2023
Merged

FM-99: Ethereum API methods (Part 3) #124

merged 18 commits into from
Jun 20, 2023

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Jun 8, 2023

Part of consensus-shipyard/ipc#342

This PR carries on from #119 by creating a transaction to transfer tokens between two Ethereum accounts. The only method implemented is eth_sendRawTransaction. The tests use a Wallet from the ethers library to sign transactions.

The API does not work with regular accounts, so the smoke-test setup creates two new accounts: emily and eric.

Because consensus-shipyard/ipc#336 is not implemented on the Application side yet, the PR disables signature checking for delegated addresses.

Follow up

The next PRs will continue building out new methods, as well as utilise sending raw transactions more:

  • Implement signature checks by to turning the FVM message back to an ETH transaction and hashing it: FM-114: Ethereum signature check #127
  • Deploy and call a smart contract.
  • Implement gas estimates and local calls, now that we have the code to map transactions to FVM messages.

@aakoshh aakoshh marked this pull request as ready for review June 20, 2023 14:08
@aakoshh aakoshh requested a review from adlrocha June 20, 2023 14:09
@aakoshh aakoshh merged commit a2e5305 into master Jun 20, 2023
@aakoshh aakoshh deleted the fm-99-eth-methods-3 branch June 20, 2023 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant