This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Fix estimate gas #161
Merged
Fix estimate gas #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
approved these changes
Jul 25, 2023
Cargo.toml
Outdated
| @@ -63,12 +63,12 @@ tracing-subscriber = "0.3" | |||
|
|
|||
|
|
|||
| # Stable FVM dependencies from crates.io | |||
| fvm = { version = "3.4", default-features = false } # no opencl feature or it fails on CI | |||
| fvm = { version = "=3.3", default-features = false } # no opencl feature or it fails on CI | |||
There was a problem hiding this comment.
Could have use ~3.3 but I doubt they will release patches retrospectively so it's okay.
docs/running.md
Outdated
| We can try query the chain id by: | ||
| ```shell | ||
| curl -X POST -i -H 'Content-Type: application/json' -d '{"jsonrpc":"2.0","id":0,"method":"eth_chainId","params":[]}' http://localhost:8545 | ||
| ``` |
There was a problem hiding this comment.
It would be great to mention it at the bottom of the doc that together with this container we can run the ethers example as well to see a fully Ethereum compliant interaction with the API.
There was a problem hiding this comment.
@cryptoAtwill, do you mind picking up this one?
|
Sorry, folks. I didn't know this PR was already a thing and I was working on this same branch to build upon @cryptoAtwill changes to |
aakoshh
reviewed
Jul 28, 2023
Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com>
* add some traces * improve gas estimation logic * clean comments * fix linter * remove unused println * FM-163: address review and prevent panic errors * FIX: make linter happy * FM-163: clean code and finish review * FM-163: rm prints * FM: add transaction compat to call query (#170) * FM-163: modify cache semantics in call * FM-163: fix gas_fee_cap and add fvm settings to config * FM-163: fix use_cache and config --------- Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com>
Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending transactions, we cannot estimate gas due to invalid serialisation error. This is because
ethers-rustrequires thetransaction typeto be zero padded hex string while hardhat does not enforce zero padding.We propose a temporary solution as follows:
Since we only use
Eip1559TransactionRequest, we created a newTypedTransactionthat uses onlyEip1559TransactionRequest. When deserializing, we use alias that handles both zero padding and non zero padding.See gakonst/ethers-rs#2518 for
ethersfix for this issue.