Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

update create subnet gateway type to address #117

Merged
merged 1 commit into from
Jun 12, 2023
Merged

update create subnet gateway type to address #117

merged 1 commit into from
Jun 12, 2023

Conversation

cryptoAtwill
Copy link
Collaborator

@cryptoAtwill cryptoAtwill commented Jun 12, 2023 •
edited
Loading

Changes

  • Change the create subnet parameter's gateway type from u64 to Address. This is because we need to support f4 address type, i.e. EVM address, using an id might not work for EVM.

Tests

cargo test --all

Issues

adlrocha
adlrocha suggested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@adlrocha adlrocha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make gateway address throughout the rest of the actors an Address for consistency.

@adlrocha adlrocha merged commit c995cd9 into main Jun 12, 2023
@adlrocha adlrocha deleted the create_subnet_address branch June 12, 2023 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adlrocha adlrocha adlrocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptoAtwill @adlrocha