This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Cross execution #75
Merged
Cross execution #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2023 16:10
adlrocha
suggested changes
Mar 23, 2023
There was a problem hiding this comment.
Looking good. You left a few things behind after our sync like releasing the fee, or removing ApplyMessage. Let's get them fixed and we can merge.
You may also want to rebase the target branch from main, I see this PR also includes the set multiaddress changes I added this weekend. 🙏
adlrocha
reviewed
Mar 23, 2023
adlrocha
approved these changes
Mar 24, 2023
| // check top down msgs | ||
| for i in 1..messages.len() { | ||
| match messages[i - 1].nonce().cmp(&messages[i].nonce()) { | ||
| Ordering::Less => {} |
There was a problem hiding this comment.
@cryptoAtwill, I don´t think we should throw an error here. Let's just order them in case they are not ordered and return them. If the checkpoint was committed here it was because all the validators agreed on that, so we can trust the messages (is not the same as for cron checkpoints). Let's discuss if this is not clear.
* fix clippy * fmt code
|
With tests merged I guess we can merge this one to the feature branch, right? (just double-checking) |
|
@adlrocha yep, time to merge! |
cryptoAtwill
added a commit
that referenced
this pull request
Apr 3, 2023
* track validators * add validator check to submit cron * update impl * weighted vote * Update gateway/src/cron.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update method name * add tests * refactor pending epoches * fix clippy * add more tests * initial commit * Cross execution (#75) * update bottom up execution * update cross message execution * fix fmt * update review and clean up * check message ordering * Cross execution tests (#76) * fix clippy * fmt code --------- Co-authored-by: adlrocha <adlrocha@tutamail.com>
adlrocha
added a commit
that referenced
this pull request
Apr 5, 2023
* track validators * add validator check to submit cron * update impl * weighted vote * Update gateway/src/cron.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update method name * add tests * refactor pending epoches * fix clippy * add more tests * initial commit * Cross execution (#75) * update bottom up execution * update cross message execution * fix fmt * update review and clean up * check message ordering * Cross execution tests (#76) * fix clippy * fmt code * generics for cron submission * migrate to sdk * format code * remove wip field * work in progress * local changes * reorg code * update comment * update tests * format code and clippy * fix error --------- Co-authored-by: adlrocha <adlrocha@tutamail.com>
adlrocha
added a commit
that referenced
this pull request
Apr 10, 2023
* add cron fields * fmt code * Update gateway/src/state.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * Update gateway/src/types.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update cron (#65) * update cron * fix lint --------- Co-authored-by: willesxm <willeslau@gmail.com> * add submit cron impl * add more checks * add some todo * derive total validators * add todo * specify rust tool chain * add tests * support abort * simplify impl * Track validators (#70) * track validators * add validator check to submit cron * update impl * Weighted vote (#71) * track validators * add validator check to submit cron * update impl * weighted vote * Update gateway/src/cron.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update method name --------- Co-authored-by: adlrocha <adlrocha@tutamail.com> * Cron submit tests (#73) * track validators * add validator check to submit cron * update impl * weighted vote * Update gateway/src/cron.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update method name * add tests * refactor pending epoches * fix clippy * add more tests --------- Co-authored-by: adlrocha <adlrocha@tutamail.com> * Refactor checkpoints (#74) * track validators * add validator check to submit cron * update impl * weighted vote * Update gateway/src/cron.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update method name * add tests * refactor pending epoches * fix clippy * add more tests * initial commit * Cross execution (#75) * update bottom up execution * update cross message execution * fix fmt * update review and clean up * check message ordering * Cross execution tests (#76) * fix clippy * fmt code --------- Co-authored-by: adlrocha <adlrocha@tutamail.com> * cargo fmt * Vote checkpoints (#81) * track validators * add validator check to submit cron * update impl * weighted vote * Update gateway/src/cron.rs Co-authored-by: adlrocha <adlrocha@tutamail.com> * update method name * add tests * refactor pending epoches * fix clippy * add more tests * initial commit * Cross execution (#75) * update bottom up execution * update cross message execution * fix fmt * update review and clean up * check message ordering * Cross execution tests (#76) * fix clippy * fmt code * generics for cron submission * migrate to sdk * format code * remove wip field * work in progress * local changes * reorg code * update comment * update tests * format code and clippy * fix error --------- Co-authored-by: adlrocha <adlrocha@tutamail.com> * rename checkpoints to bottomup and topdown * fix tests * use CrossMsg for topdown checkpoint * fix checkpoint (#85) * update queue serialization (#86) * update queue serialization * remove println * fix fmt * genesis_epoch bottomup checkpoints to zero * fix test with new genesis checkpoint --------- Co-authored-by: willesxm <willeslau@gmail.com> Co-authored-by: adlrocha <adlrocha@tutamail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add execution of bottom up messages.