Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Bottom up checkpoint proof #199

Merged
merged 7 commits into from
May 17, 2023
Merged

Bottom up checkpoint proof #199

merged 7 commits into from
May 17, 2023

Conversation

cryptoAtwill
Copy link
Contributor

Support more complex bottom up proof as described in consensus-shipyard/ipc#427.

@cryptoAtwill cryptoAtwill changed the base branch from main to refactor_checkpoint May 17, 2023 08:49
adlrocha
adlrocha approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a slight change on how we construct the proof, but LGTM. If you have tested it and it works let's get this one merged :)

src/manager/checkpoint/proof/v1.rs Outdated Show resolved Hide resolved
src/manager/checkpoint/proof/mod.rs Outdated Show resolved Hide resolved
@cryptoAtwill @adlrocha
Update src/manager/checkpoint/proof/mod.rs
96a85df 
Co-authored-by: adlrocha <adlrocha@tutamail.com>
@adlrocha adlrocha mentioned this pull request May 17, 2023
Merged
@adlrocha adlrocha merged commit 3278a82 into refactor_checkpoint May 17, 2023
@adlrocha adlrocha deleted the checkpoint_proof branch May 17, 2023 16:11
@adlrocha adlrocha mentioned this pull request May 18, 2023
Closed
adlrocha added a commit that referenced this pull request May 18, 2023
@cryptoAtwill @jsoares
@aakoshh @adlrocha
Refactor checkpoint submission (#175)
255cd80 
* refactored code

* add sleep

* update sleep sec

* reorg code

* simplify

* migrate bottom up checkpoint (#182)

* Fix typo

* IPC-91: Test env (Part 1) (#157)

* IPC-91: Fix infra directory mkdir. Exit on fail.

* IPC-91: Update init config command

* IPC-91: Makefile to build the agent and eudico

* IPC-91: Allow empty subnets list

* IPC-91: Create agent docker-compose, up and down

* IPC-91: make clean

* IPC-91: Trying to get a eudico node going

* IPC-91: Separate daemon and validator

* IPC-91: Docs and clean

* IPC-91: Fix API address for the validator

* IPC-91: Remove volumes

* IPC-91: Copy the infra scripts that needed modification.

* IPC-91: Connect script. Fix clean

* IPC-91: Try reload the agent config

* IPC-91: Fix host to accept connections

* IPC-91: Sleep after wait. Fix finding files and config when no subnets yet

* IPC-91: Tab to spaces

* IPC-91: Spaces to tabs

* IPC-91: Config not needed to call reload

* IPC-91: Test environment (Part 2) (#161)

* IPC-91: make wallet

* IPC-91: Create a wallet for a child node

* IPC-91: Keep just one subnet-validator script

* IPC-91: Create new subnet

* IPC-91: Refer to the wallet key rather than copy.

* IPC-91: Start agent by number

* IPC-91: Create topology

* IPC-91: Fixes, stop on error

* IPC-91: Fix target in setup

* IPC-91: Remove agent NR from node env

* IPC-91: Comments and docs

* IPC-91: Simpler subnet to demonstrate the error

* IPC-91: Trying to fund the wallet created

* IPC-91: Copy genesis files. Use the one with funds in root

* IPC-91: Allow adding subnet variables to the topology

* IPC-91: Move wallet out of genesis directory

* IPC-91: Various fixes

* IPC-91: Rename to topologies

* IPC-91: Join subnet

* IPC-91: Trying to fund the subnet

* IPC-91: Add explicit step tombstones so funding only happens once

* IPC-91: Add explicit step tombstone to the agent as well.

* IPC-91: Join first, then fund

* IPC-91: Add env var to construct agent URL to the node

* IPC-91: Fix CLI to exit with error code

* IPC-91: Fix equality check

* IPC-91: Get rid of the wallet address from the validator net addr.

* IPC-91: Fix address in root

* IPC-91: Give the validator another chance to start

* IPC-91: Remove any newlines after docker capture

* IPC-91: Fix shadowing of env vars

* IPC-91: Ephasize topologies

* IPC-91: Remove leftover script

* migrate bottom up checkpoint

* add get validators and submit

* Update src/lotus/client.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Update src/lotus/mod.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* make obtain validator common

* handle error responses

* abstract common methods

* more logs and concurrent futures

* add pre submission checks:

* make lint

* remove unused method

* Migrate top down (#184)

* wip

* merge with bottom up

* merge with bottom up

* Update src/manager/checkpoint/manager/topdown.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Update src/manager/checkpoint/manager/topdown.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Update src/manager/checkpoint/manager/topdown.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Integrate new checkpoint (#185)

* integrate new checkpoint system

* format code

* add error logging

* add more logging

* add epoch of fund and release

* add more logging

* update info

* update bottom up

* update comment

* update log

* update logging

* remove subsystem file

---------

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* remove default gateway address const (#188)

---------

Co-authored-by: Jorge Soares <547492+jsoares@users.noreply.github.com>
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: adlrocha <adlrocha@tutamail.com>

* update comments

* Bottom up checkpoint proof (#199)

* add bottom up proof

* format proof

* wrap inner proof

* update comment

* Update src/manager/checkpoint/proof/mod.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* update proof state

* Update src/manager/checkpoint/proof/v1.rs

---------

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* update mem push method

* update response

* share key store

* add subnet to lotus client

* fix docs

---------

Co-authored-by: Jorge Soares <547492+jsoares@users.noreply.github.com>
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: adlrocha <adlrocha@tutamail.com>
adlrocha added a commit that referenced this pull request May 22, 2023
@cryptoAtwill @jsoares
@aakoshh @adlrocha
Fix checkpoint config load (#205)
17a6445 
* refactored code

* add sleep

* update sleep sec

* reorg code

* simplify

* migrate bottom up checkpoint (#182)

* Fix typo

* IPC-91: Test env (Part 1) (#157)

* IPC-91: Fix infra directory mkdir. Exit on fail.

* IPC-91: Update init config command

* IPC-91: Makefile to build the agent and eudico

* IPC-91: Allow empty subnets list

* IPC-91: Create agent docker-compose, up and down

* IPC-91: make clean

* IPC-91: Trying to get a eudico node going

* IPC-91: Separate daemon and validator

* IPC-91: Docs and clean

* IPC-91: Fix API address for the validator

* IPC-91: Remove volumes

* IPC-91: Copy the infra scripts that needed modification.

* IPC-91: Connect script. Fix clean

* IPC-91: Try reload the agent config

* IPC-91: Fix host to accept connections

* IPC-91: Sleep after wait. Fix finding files and config when no subnets yet

* IPC-91: Tab to spaces

* IPC-91: Spaces to tabs

* IPC-91: Config not needed to call reload

* IPC-91: Test environment (Part 2) (#161)

* IPC-91: make wallet

* IPC-91: Create a wallet for a child node

* IPC-91: Keep just one subnet-validator script

* IPC-91: Create new subnet

* IPC-91: Refer to the wallet key rather than copy.

* IPC-91: Start agent by number

* IPC-91: Create topology

* IPC-91: Fixes, stop on error

* IPC-91: Fix target in setup

* IPC-91: Remove agent NR from node env

* IPC-91: Comments and docs

* IPC-91: Simpler subnet to demonstrate the error

* IPC-91: Trying to fund the wallet created

* IPC-91: Copy genesis files. Use the one with funds in root

* IPC-91: Allow adding subnet variables to the topology

* IPC-91: Move wallet out of genesis directory

* IPC-91: Various fixes

* IPC-91: Rename to topologies

* IPC-91: Join subnet

* IPC-91: Trying to fund the subnet

* IPC-91: Add explicit step tombstones so funding only happens once

* IPC-91: Add explicit step tombstone to the agent as well.

* IPC-91: Join first, then fund

* IPC-91: Add env var to construct agent URL to the node

* IPC-91: Fix CLI to exit with error code

* IPC-91: Fix equality check

* IPC-91: Get rid of the wallet address from the validator net addr.

* IPC-91: Fix address in root

* IPC-91: Give the validator another chance to start

* IPC-91: Remove any newlines after docker capture

* IPC-91: Fix shadowing of env vars

* IPC-91: Ephasize topologies

* IPC-91: Remove leftover script

* migrate bottom up checkpoint

* add get validators and submit

* Update src/lotus/client.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Update src/lotus/mod.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* make obtain validator common

* handle error responses

* abstract common methods

* more logs and concurrent futures

* add pre submission checks:

* make lint

* remove unused method

* Migrate top down (#184)

* wip

* merge with bottom up

* merge with bottom up

* Update src/manager/checkpoint/manager/topdown.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Update src/manager/checkpoint/manager/topdown.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Update src/manager/checkpoint/manager/topdown.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* Integrate new checkpoint (#185)

* integrate new checkpoint system

* format code

* add error logging

* add more logging

* add epoch of fund and release

* add more logging

* update info

* update bottom up

* update comment

* update log

* update logging

* remove subsystem file

---------

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* remove default gateway address const (#188)

---------

Co-authored-by: Jorge Soares <547492+jsoares@users.noreply.github.com>
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: adlrocha <adlrocha@tutamail.com>

* update comments

* Bottom up checkpoint proof (#199)

* add bottom up proof

* format proof

* wrap inner proof

* update comment

* Update src/manager/checkpoint/proof/mod.rs

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* update proof state

* Update src/manager/checkpoint/proof/v1.rs

---------

Co-authored-by: adlrocha <adlrocha@tutamail.com>

* update mem push method

* update response

* share key store

* add subnet to lotus client

* fix docs

* load config should not crash programme

* load config should not crash programme

* wait for config reload

* Update mod.rs

---------

Co-authored-by: Jorge Soares <547492+jsoares@users.noreply.github.com>
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: adlrocha <adlrocha@tutamail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adlrocha adlrocha adlrocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptoAtwill @adlrocha