Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Commit

Permalink
Fix Slither fps
Browse files Browse the repository at this point in the history
  • Loading branch information
dnkolegov committed Dec 18, 2023
1 parent 156e8f6 commit ac35129
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/gateway/GatewayManagerFacet.sol
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ contract GatewayManagerFacet is GatewayActorModifiers, ReentrancyGuard {
// prevent spamming if there's no value to fund.
revert InvalidCrossMsgValue();
}
// slither-disable-next-line unused-return
(bool registered, ) = LibGateway.getSubnet(subnetId);
if (!registered) {
revert NotRegisteredSubnet();
Expand Down
2 changes: 1 addition & 1 deletion src/gateway/GatewayMessengerFacet.sol
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ contract GatewayMessengerFacet is GatewayActorModifiers {
// to propagate, the user won't be able to reclaim funds. That's one of the
// reasons xnet messages are disabled by default.

bool reject;
bool reject = false;
if (applyType == IPCMsgType.BottomUp) {
// We're traversing up, so if we're the first hop, we reject if the subnet was ERC20.
// If we're not the first hop, a child propagated this to us, they made a mistake and
Expand Down
1 change: 1 addition & 0 deletions src/gateway/GatewayRouterFacet.sol
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ contract GatewayRouterFacet is GatewayActorModifiers {
}

// Now, let's find out the directionality of this message and act accordingly.
// slither-disable-next-line uninitialized-local
SupplySource memory supplySource;
IPCMsgType applyType = crossMsg.message.applyType(s.networkName);
if (applyType == IPCMsgType.BottomUp) {
Expand Down

0 comments on commit ac35129

Please sign in to comment.