This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Minor fixes #163
Merged
Minor fixes #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
approved these changes
Jul 28, 2023
| @@ -2333,7 +2333,7 @@ contract GatewayDiamondDeploymentTest is StdInvariant, Test { | |||
| } | |||
|
|
|||
| function callback() public view { | |||
| console.log("callback called"); | |||
| // console.log("callback called"); | |||
There was a problem hiding this comment.
Is this on purpose? Why do we need to comment it (and not even remove it all the way?)
adlrocha
added a commit
that referenced
this pull request
Jul 28, 2023
* Draft facets * constructor * update draft * drafting * new getter * draft * fix bug * update tests * update tests * fix tests * format * fix console * fix console * fix test * update github actions * update pip * update pip * fix linting * refactor info facet * fix subnet facet * fix router facet * fix router facet * fix lib * update reentrancy * format * init sa diamond * fix all * update tests * make getters * Refactor src * add test util * fix getters * fix visibility * update getters * fix format * remove console * update makefile * add readme * remove constructors * deploy diamond * comment libs * fix test flow * build * build * build * update * resolve conflicts * format * fix slither findings * fix linting * fix linting * Fix foundry * Update src/interfaces/IDiamond.sol * minor fix * comment * uncomment libs * Fixing addr * fix readme * fix depl scripts * Add louper * fix linting * fix testGatewayDiamond_SubmitTopDownCheckpoint_FuzzNumberOfMessages * fix format * Update epoch processing (#155) * Adopt epoch validation * Fix epoch in ExecutableQueueHelper * fix linting * Add tests for libvoring * add listSubnets * Fix tests * Fix misprint in test * Diamond registry (#153) * integrate diamond subnet registry * make selectors storage * revert openzeppelin changes * more comments * update registry template * fix error * fix error * fix error * fix errors * fix errors * fix errors * fix tests * fix tests * update template * reduce registry size * remove unused methods * clean up code * update registry * add clone factory * more logs * update deployment script * remove compile * format * update template * remove clone factory * remove clone factory * fix test * revert deleted functions * update deployment * remove extra logs * fix test setup * fixing unit tests * fixing unit tests * fix latest subnet bug * update nonce when subnet created * update comment * Add storage checker (#157) * Add storage checker * Run workflows for feature branches * Diamond patches (#158) * add nonce to get top down msgs * add bottomUpCheckPeriod * Subnet registry fixes (#159) * Fix bottom up checkpoint period (#160) fix bottom up checkpoint period * update contract storage signatures * Remove old actors * Update layout * add list bottom up checkpoint * fix typo * Fix list bottom up (#161) * fix list bottom up * fix typo * make multiple of bottom up period * fix slither * make pretty --------- Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> * Minor fixes (#163) * remove deployment script for gateway --------- Co-authored-by: adlrocha <6717133+adlrocha@users.noreply.github.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: cryptoAtwill <108330426+cryptoAtwill@users.noreply.github.com> Co-authored-by: cryptoAtwill <willes.lau@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: