This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
3 - enhance the subnet registry contract to follow diamond standard #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe interspection to the gateway diamond so that we can know the current available functions
…compiled contracts, also gets the active facets on the gw diamond and prints out their bytecode from the chain. todo diff and run replace on any extra
…hipyard/ipc-solidity-actors into mikers/hardhatDiamondUpgrade
…hipyard/ipc-solidity-actors into mikers/hardhatDiamondUpgrade
…hipyard/ipc-solidity-actors into mikers/hardhatDiamondUpgrade
…update SubnetRegistry tests- WIP
adlrocha
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Overall, LGTM. Thanks!
The only thing that we should bear in mind after merging is that we will need to update the IpcProvider to use the new implementation of the contract. Tracking this issue here: consensus-shipyard/ipc#401
…d/ipc-solidity-actors into mikers/diamondRegistry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.