Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EthAccount at 0x00..00 + fix default sender address #166

Closed
raulk opened this issue Nov 7, 2023 · 3 comments · Fixed by consensus-shipyard/fendermint#409
Closed

Comments

@raulk
Copy link
Contributor

raulk commented Nov 7, 2023

This PR made us default to the system actor address in masked ID form as a sender when no from address is provided to eth_call. That address is 0xff00..00. However, clients expect this address to be 0x00..00 (the null Ethereum address). We need to do two things here:

  1. Create an EthAccount actor with an f410 address equivalent to 0x00..00. The actor ID does not matter. See how Lotus does that here.
  2. Fix eth_call to use that address as the default sender.
@raulk
Copy link
Contributor Author

raulk commented Nov 7, 2023

@cryptoAtwill are you a good person to take this on?

@aakoshh
Copy link
Contributor

aakoshh commented Nov 8, 2023

However, clients expect this address to be 0x00..00

@raulk where exactly do they expect to see this? Where do they observe 0xff00..00?

@raulk
Copy link
Contributor Author

raulk commented Nov 8, 2023

Say, for example, that a contract returns the sender address as a return value. Clients will expect that address to be 0x00..00 when the "from" field was elided. It's a long-standing convention in Eth APIs that can break random things down the line if not honoured.

@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants