-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BURNT_FUNDS_ACTOR explanation #21
Comments
There's other discussion about the value of using 0x0 as the explicit burn address with this being worth reading https://forum.openzeppelin.com/t/removing-address-0x0-checks-from-openzeppelin-contracts/2222/2 I think that it's important to consider this coding standard - use 0x0 as the explicit burn address and create specific functions for burning. The idea is to have a safeTransfer method that reverts if the 0x0 burn address used |
I think we should use the zero address for this. This is another of the "blunders" coming from the close to literal translation of the native actors implementation of IPC to Solidity that we got from the team that did it. |
Another benefit of using the 0x0 address is that there's standardized acceptance about how to measure the supply of a token by discounting anything owned by the 0x0 burn account (and the 0x29 etc burn account) |
The IDs are coming from ref-fvm. The 0x0 address became the system actor ID. |
There were apparently other expectations regarding 0x0 in #166 which lead to consensus-shipyard/fendermint#409 |
Callout that automatic restarts should be disabled when reaching halting height
address constant BURNT_FUNDS_ACTOR = address(99);
is address(99) special or just chosen to be any other burn address? Why not 0?
Interpretation of 'BURNT_FUNDS_ACTOR' as an address constant (address(99)) requires explanation. Does this address signify a special use case within the IPC context?
The text was updated successfully, but these errors were encountered: