fix(node): skip power scale if not collateral based #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoAtwill
changed the title
gvelez17
reviewed
Sep 26, 2024
| ) { | ||
| args.power_scale.unwrap_or(DEFAULT_POWER_SCALE) | ||
| } else { | ||
| TokenAmount::DECIMALS as PowerScale |
There was a problem hiding this comment.
will this be the value we put in set-federated-power? that would be great if so!
gvelez17
approved these changes
Sep 26, 2024
raulk
reviewed
Sep 26, 2024
| ) { | ||
| args.power_scale.unwrap_or(DEFAULT_POWER_SCALE) | ||
| } else { | ||
| TokenAmount::DECIMALS as PowerScale |
There was a problem hiding this comment.
@cryptoAtwill shouldn't this be 1? We want X federated power to translate directly into X weight, right? Having 18 here would force users to append 18 zeroes to whatever power they actually want to see in the subnet?
There was a problem hiding this comment.
it's a subtraction here:
ipc/fendermint/vm/genesis/src/lib.rs
Line 129 in d881a2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The power scale is used to convert collateral staked into voting power for cometbft.
With federated power, the power scale is also used to convert federated power into voting power. This has caused a lot of confusion for many ppl. For example, if one sets the federated power to 1000, with the power scale division, the voting power set in cometbft is actually 1. For those who are not aware of power scale, they constantly ask how come? This is especially bad if two validators with federated power of, say, 1000 and 1. People would assume 1000 would have a higher power, but it turns out, the two validators have the same power.
This PR makes a quick fix to resolve the above issue at genesis. If the power comes from non-collateral based, power scale is set to 18, which is effectively no power scaling.
Perhaps a more in depth refactor would be replacing the
Collateralstruct withPower, but that would require breaking changes in too many places, perhaps this way is faster and safer.